Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent env var naming for LDAP filter configuration #3898

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fix inconsistent env var naming for LDAP filter configuration #3898

merged 1 commit into from
Jun 1, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented May 31, 2022

There was a naming inconsitency for the enviroment variables used to define
LDAP filters for user and groups queries. Some services used LDAP_USER_FILTER
while others used LDAP_USERFILTER. This is now changed to use LDAP_USER_FILTER
and LDAP_GROUP_FILTER

Closes: #3890

@rhafer rhafer self-assigned this May 31, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 31, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiAccountsHashDifficulty-ocis failed. Further test are cancelled...

@wkloucek
Copy link
Contributor

@micbar should we make this backwards compatible?

@rhafer
Copy link
Contributor Author

rhafer commented May 31, 2022 •
edited
Loading

@micbar should we make this backwards compatible?

I would prefer to have this change mentioned prominently in the release notes for the next beta. If we keep this backwards compatible there would be four different envvars to configure the same setting in the users,groups and auth-basic ( LDAP_USERFILTER; USERS_LDAP_USERFILTER; LDAP_USER_FILTER; USERS_LDAP_USER_FILTER )

@micbar
Copy link
Contributor

micbar commented Jun 1, 2022

yes, we need it in the release notes.

I would like to have also a note in the changelog what needs to be done for an existing deployment.

@micbar
Copy link
Contributor

micbar commented Jun 1, 2022

@mmattel JFYI

@mmattel
Copy link
Contributor

mmattel commented Jun 1, 2022

yes, we need it in the release notes.

Inform @pmaier1 in time as he does the RN writing.

@rhafer
Fix inconsistent env var naming for LDAP filter configuration
24178e3 
There was a naming inconsitency for the enviroment variables used to define
LDAP filters for user and groups queries. Some services used `LDAP_USER_FILTER`
while others used `LDAP_USERFILTER`. This is now changed to use `LDAP_USER_FILTER`
and `LDAP_GROUP_FILTER`

Closes: owncloud#3890
@rhafer
Copy link
Contributor Author

rhafer commented Jun 1, 2022

I would like to have also a note in the changelog what needs to be done for an existing deployment.

Makes sense. I've added a Note.

micbar
micbar approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit 035cf77 into owncloud:master Jun 1, 2022
ownclouders pushed a commit that referenced this pull request Jun 1, 2022
@micbar
commit 035cf77
64f7093 
Merge: 3c3cf84 24178e3
Author: Michael Barz <[email protected]>
Date:   Wed Jun 1 16:43:02 2022 +0200

    Merge pull request #3898 from rhafer/issue3890

    Fix inconsistent env var naming for LDAP filter configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent env vars LDAP_USER_FILTER vs LDAP_USERFILTER
5 participants
@rhafer @ownclouders @wkloucek @micbar @mmattel